Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregating padding mode #35

Merged
merged 8 commits into from
Aug 12, 2024
Merged

aggregating padding mode #35

merged 8 commits into from
Aug 12, 2024

Conversation

keewis
Copy link
Member

@keewis keewis commented Aug 12, 2024

This adds the mean, minimum, and maximum padding modes as aggregations. Additionally, it also contains code for a median mode, but this is broken because median does not support the where parameter. Fixed by moving to nanreduce, which also allows dask to work properly.

These modes are implemented by searching the neighbours of the padded cells. Depending on how costly this is, we might want to switch to grouping the neighbours of the input cells by the cell ids of the padded cells.

@keewis keewis merged commit 2d58d9c into IAOCEA:main Aug 12, 2024
6 checks passed
@keewis keewis deleted the padding-agg branch August 12, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant